Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generators fixes -- Fix for GeneratorInterface/LHEInterface/test/testPythia8_cfg.py #805

Merged
merged 1 commit into from Sep 21, 2013
Merged

Generators fixes -- Fix for GeneratorInterface/LHEInterface/test/testPythia8_cfg.py #805

merged 1 commit into from Sep 21, 2013

Conversation

andreh7
Copy link

@andreh7 andreh7 commented Sep 12, 2013

see the description in the commit message of 5d06c7d

made testPythia8_cfg.py run again on e.g. CMSSW_6_2_1
5d06c7d 
(but a similar problem appears on 5_3_2_patch4):

 - made LHEProducer an EDFilter instead of an EDProducer in the python
   configuration

 - changed Configuration.StandardSequences.VtxSmearedGauss_cff
   to IOMC.EventVertexGenerators.VtxSmearedGauss_cfi
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andreh7 for CMSSW_6_2_X.

fix for GeneratorInterface/LHEInterface/test/testPythia8_cfg.py

It involves the following packages:

GeneratorInterface/LHEInterface

@vciulli can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@vciulli
Copy link
Contributor

vciulli commented Sep 13, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it?

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it?

ktf added a commit that referenced this pull request Sep 21, 2013
@ktf
Merge pull request #805 from andreh7/ah-2013-09-12b-lhe-test-fix
bebd593 
Generators fixes -- Fix for GeneratorInterface/LHEInterface/test/testPythia8_cfg.py
@ktf ktf merged commit bebd593 into cms-sw:CMSSW_6_2_X Sep 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed generators-approved tests-pending
Projects
None yet
Milestone
CMSSW_6_2_2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andreh7 @cmsbuild @vciulli @fabiocos @ktf