Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch by default to new flavour tool based on Hadrons. Update of exampl... #8056

Merged
merged 3 commits into from May 20, 2015

Conversation

acaudron
Copy link

@acaudron acaudron commented Mar 4, 2015

...e scripts.
Same as PR#8049 for 75x:
Switch for the Btag DQM to the new jet flavour tool described here:
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideBTagMCTools#Hadron_based_jet_flavour_definit
and already default in PAT.
Examples scripts are also updated accordingly.
Possibility to use the old flavour tool is conserved, especially as the new tool, targeting PFJets, cannot be applied on some jet collections as CaloJets.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @acaudron for CMSSW_7_4_X.

Switch by default to new flavour tool based on Hadrons. Update of exampl...

It involves the following packages:

DQMOffline/RecoB
Validation/RecoB

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@ferencek
Copy link
Contributor

@davidlange6, can you please merge this PR (it's been fully approved for more than a week and its 75X equivalent #8049 has already been merged)

@ferencek
Copy link
Contributor

What's the hold up here?

@ferencek
Copy link
Contributor

ferencek commented Apr 2, 2015

This PR got left out of the final 740 release. Was there a specific reason for that and can this PR be included in a later 74X release?

@davidlange6
Copy link
Contributor

@ferencek - pushing new features back to 74x needs some validation first in 75x (so pre1) - we can back port these changes to 74x in the coming weeks.

@ferencek
Copy link
Contributor

ferencek commented Apr 7, 2015

@davidlange6, thank you for clarifying.

@ferencek
Copy link
Contributor

Based on the previous discussion, I assume this PR can now be merged.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request May 20, 2015
Switch by default to new flavour tool based on Hadrons. Update of exampl...
@cmsbuild cmsbuild merged commit 2a9756b into cms-sw:CMSSW_7_4_X May 20, 2015
@ferencek ferencek deleted the DQMBtagNewJetFlav branch May 20, 2015 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants