Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu updates 74X #8071

Merged
merged 3 commits into from Mar 16, 2015
Merged

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Mar 4, 2015

Update the HLT menu for Run2 on top of #7915 with the following additions:

  • Fix two sequences from where HLTDoFullUnpackingEgammaEcalSequence was missing, after CMSHLT-246
  • Move muon PF isolation to regional PF isolation around muon, CMSHLT-272
  • Low-lumi single Electron paths, CMSHLT-269
  • Monitoring paths for Tracker and for DT's, CMSHLT-261
  • FSQ paths for LHCf run, CMSHLT-260
  • Fix two PSets for Tracking
  • Add hltESPChi2MeasurementEstimatorNN ESModules, to be used in the 50ns menu.
  • Threshold fix for two dilepton + HT trigger, CMSHLT-271
  • Rename the electron sequence of the Ele22+Tau20 path for 25ns, CMSHLT-270
  • More fixes from CMSHLT-246: change parameter value and remove HLTDoFullUnpackingEgammaEcalSequence from HLTPFClusteringForEgammaUnseeded

This is the 74X version of #8070

The other signatures besides HLT are only needed here because I had to merge the previous #7915, on which this pull request depends, and which is fully signed by now (even if not yet merged in 74X). If this pull request will be fully signed again before #7915 gets merged, then we can close the old one and continue with this one only. Otherwise, once #7915 is merged we will rebase this one and the need for the other signatures will disappear

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @perrotta for CMSSW_7_4_X.

HLT menu updates 74X

It involves the following packages:

HLTrigger/Configuration
L1Trigger/L1TCommon
RecoLocalCalo/EcalRecProducers

@perrotta, @cmsbuild, @nclopezo, @cvuosalo, @fwyzard, @Martin-Grunewald, @slava77, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor Author

perrotta commented Mar 4, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

@perrotta , @Martin-Grunewald, @diguida - fwiw, workflow 1311 has failed since this update to the HLT went in (I had not noticed)

n exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 5 event: 1201
[1] Running path 'pathALCARECOEcalCalPhiSym'
[2] Calling event method for module EcalRecalibRecHitProducer/'ecalPhiSymCorrected'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::SortedCollection >
Looking for module label: hltAlCaPhiSymStream
Looking for productInstanceName: phiSymEcalRecHitsEB

@Martin-Grunewald
Copy link
Contributor

Hi,
This PR added in the new path AlCa_EcalPhiSym_v1 which however is different from its Run-1
version in that it does not contain a module hltAlCaPhiSymStream.
In fact the new version is:

AlCa_EcalPhiSym_v1 = cms.Path(   HLTBeginSequence +   hltL1sL1ZeroBias +   hltPreAlCaEcalPhiSym +   HLTDoFullUnpackingEgammaEcalSequence +   hltEcalPhiSymFilter +   HLTEndSequence )

while in Run-1 we had:

cms.Path( process.HLTBeginSequence + process.hltL1sL1ZeroBias + process.hltPreAlCaEcalPhiSym + process.hltEcalRawToRecHitFacility  + process.hltESRawToRecHitFacility + process.hltEcalRegionalRestFEDs + process.hltEcalRecHitAll + process.hltAlCaPhiSymStream + process.hltAlCaPhiSymUncalibrator + process.HLTEndSequence )

So I believe it is a matter of updating the failing path pathALCARECOEcalCalPhiSym
to the new AlCa_EcalPhiSym_v1 path, or adding some more modules to the current path.

It may simply be a matter of renaming hltEcalPhiSymFilter to hltAlCaPhiSymStream
in HLT, or the other way around in ecalPhiSymCorrected,
We imported the current version of the path into the HLT menu as was requested here:
https://its.cern.ch/jira/browse/CMSHLT-276

@Martin-Grunewald
Copy link
Contributor

In any case ecalPhiSymCorrected should not crash on the missing product, since in principle not all events would have to contain the missing product even if the path is in the menu (eg, HLT may decide to prescale it away for some operational online reason).

@fwyzard
Copy link
Contributor

fwyzard commented Mar 22, 2015

let's move the follow up to the hypernews: https://hypernews.cern.ch/HyperNews/CMS/get/hlt/3803.html

@Martin-Grunewald Martin-Grunewald deleted the hltMenuUpdates_74X branch June 2, 2015 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants