Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize multi-threaded image saving #8079

Merged
merged 2 commits into from Mar 10, 2015
Merged

Optimize multi-threaded image saving #8079

merged 2 commits into from Mar 10, 2015

Conversation

osschar
Copy link
Contributor

@osschar osschar commented Mar 4, 2015

Reuse as many resources as possible for online image capture:

  • keep one image saving thread per eve view;
  • reuse FBO objects (as long as they keep the same size);
  • reuse intermediate buffers for image creation.
    All this shaves off about 10% of execution time when saving 5 extremely large images.

@osschar
Reuse as many resources as possible for online image capture:
6a97d6d 
- keep one image saving thread per eve view;
- reuse FBO objects (as long as they keep the same size);
- reuse intermediate buffers for image creation.
All this shaves off about 10% of execution time when saving 5 extremely large images.
@osschar
Copy link
Contributor Author

osschar commented Mar 4, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Mar 4, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2015

A new Pull Request was created by @osschar (Matevž Tadel) for CMSSW_7_3_X.

Optimize multi-threaded image saving

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@osschar osschar mentioned this pull request Mar 4, 2015
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

+1
Tested at: d10d3cb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8079/6426/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

Pull request #8079 was updated. @alja, @Dr15Jones, @ktf can you please check and sign again.

@alja
Copy link
Contributor

alja commented Mar 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 10, 2015
@cmsbuild
Merge pull request #8079 from osschar/from-CMSSW_7_3_2_patch4
7840bd2 
Optimize multi-threaded image saving
@cmsbuild cmsbuild merged commit 7840bd2 into cms-sw:CMSSW_7_3_X Mar 10, 2015
@osschar osschar deleted the from-CMSSW_7_3_2_patch4 branch March 10, 2015 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed tests-approved visualization-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@osschar @cmsbuild @alja @davidlange6