CMSSW 7 0 X switch to consumes API

[mileva]

Code modified to use the consumes API. getByLabel() invokations are replaced with getByToken().

[cmsbuild]

A new Pull Request was created by @mileva for CMSSW_7_0_X.

CMSSW 7 0 X switch to consumes API

It involves the following packages:

Validation/MuonRPCDigis

@rovere, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[nclopezo]

Hi,

I ran the usual tests on top of CMSSW_7_0_X_2013-09-12-0200, all tests passed:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/477/console

you can see the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/477

[deguio]

ciao @mileva thanks for the changes.
I was wondering if you could also take care of moving the histogram booking in the beginRun. I see that it is done in the beginJob.
The reason why this is needed has been discussed back in June. see:
https://indico.cern.ch/getFile.py/access?contribId=3&resId=0&materialId=slides&confId=256775

thank you in advance,
F.

@rovere @danduggan

[cmsbuild]

Pull request #808 was updated. @danduggan, @rovere, @deguio can you please check and sign again.

[deguio]

is there a reason why you left this one?

[deguio]

@mileva I would just replace it with an empty string as it was before.
thanks,
F.

@rovere

[mileva]

OK,
leave the empty string.
Thanks!
Roumyana

---

From: deguio [notifications@github.com]
Sent: 18 September 2013 13:44
To: cms-sw/cmssw
Cc: Roumyana Mileva Hadjiiska
Subject: Re: [cmssw] CMSSW 7 0 X switch to consumes API (#808)

@milevahttps://github.com/mileva I would just replace it with an empty string as it was before.
thanks,
F.

@roverehttps://github.com/rovere

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/808#issuecomment-24658162.

[deguio]

@mileva can you implement the change and commit the code again please?
thanks in advance,
F.

[cmsbuild]

Pull request #808 was updated. @danduggan, @nclopezo, @rovere, @deguio can you please check and sign again.

[ktf]

Please do not comment old code. Just remove it.

[cmsbuild]

Pull request #808 was updated. @danduggan, @nclopezo, @rovere, @deguio can you please check and sign again.

[nclopezo]

+1
https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc481/589/console
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/589

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

[deguio]

see the discussion in #807
@mileva @eliasron