Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved genTau decay mode finding for tau trigger DQM #8087

Merged
merged 3 commits into from Mar 10, 2015

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Mar 5, 2015

This request is to integrate an improved tau decay product finding for tau trigger DQM using new status flags introduced to genParticle dataformat. The imporved code works correctly with Pythia6 and Pythia8 samples, which was not the case with the old code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @mbluj for CMSSW_7_5_X.

Improved genTau decay mode finding for tau trigger DQM

It involves the following packages:

HLTriggerOffline/Tau

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mbluj
Copy link
Contributor Author

mbluj commented Mar 5, 2015

This request should be backported to 74X when the new status flags of genParticle dataformat are also available in this release series (#7812)

@deguio
Copy link
Contributor

deguio commented Mar 5, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

Pull request #8087 was updated. @cmsbuild, @danduggan, @nclopezo, @deguio can you please check and sign again.

@mbluj
Copy link
Contributor Author

mbluj commented Mar 5, 2015

Tested with CMSSW_7_5_X_2015-03-04-0200. Do you want some proof (plots) justifg it works as the old version with Py6?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

@deguio
Copy link
Contributor

deguio commented Mar 10, 2015

+1
@mbluj my request of testing was for the bot, not for you.. ;)
ciao and thanks,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

1 similar comment
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 10, 2015
Improved genTau decay mode finding for tau trigger DQM
@cmsbuild cmsbuild merged commit b2d4a72 into cms-sw:CMSSW_7_5_X Mar 10, 2015
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Mar 10, 2015
Improved genTau decay mode finding for tau trigger DQM
@mbluj mbluj deleted the genParticleStatusFix branch September 7, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants