Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root6 version numbers should be known to Root5 #8106

Merged
merged 1 commit into from Mar 7, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Mar 5, 2015

Root6 class version numbers should be known to ROOT5. This prevents serious problems.
This PR is totally technical, as all it does is add version numbers for ROOT6 into the ROOT5 IB. It changes absolutely nothing in ROOT5. No version numbers or checksums or code is modified.
I suggest that L2's be given a reasonable time to sign or comment, and if they do not, the L2 signature(s) should be bypassed.

@wmtan wmtan closed this Mar 5, 2015
@wmtan wmtan reopened this Mar 5, 2015
@wmtan
Copy link
Contributor Author

wmtan commented Mar 5, 2015

I momentarily closed this pull request because this PR was intended for 7_4_X and I requested it for 7_5_X. Further inspection revealed that it is OK for 7_5_X also, so I reopened it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2015

A new Pull Request was created by @wmtan for CMSSW_7_5_X.

Root6 version numbers should be known to Root5

It involves the following packages:

AnalysisDataFormats/SUSYBSMObjects
AnalysisDataFormats/TrackInfo
CondFormats/SiStripObjects
DataFormats/BTauReco
DataFormats/BeamSpot
DataFormats/CaloRecHit
DataFormats/Candidate
DataFormats/DTRecHit
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/FEDRawData
DataFormats/GsfTrackReco
DataFormats/HepMCCandidate
DataFormats/L1GlobalCaloTrigger
DataFormats/L1GlobalTrigger
DataFormats/L1Trigger
DataFormats/MuonReco
DataFormats/MuonSeed
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
DataFormats/RecoCandidate
DataFormats/SiStripCommon
DataFormats/TauReco
DataFormats/TrackCandidate
DataFormats/TrackReco
DataFormats/TrackerRecHit2D
DataFormats/TrajectorySeed
FastSimDataFormats/External
FastSimDataFormats/NuclearInteractions
SimDataFormats/GeneratorProducts

@vciulli, @civanch, @diguida, @bendavid, @lveldere, @cvuosalo, @emeschi, @ssekmen, @thuer, @monttj, @cmsbuild, @ggovi, @covarell, @mdhildreth, @cerminar, @slava77, @mommsen, @vadler, @mmusich, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
@apfeiffer1, @Sam-Harper, @imarches, @makortel, @trocino, @acaudron, @abbiendi, @lgray, @jpavel, @threus, @ferencek, @battibass, @VinInn, @pvmulder, @amagitte, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

The tests are being triggered in jenkins.

@wmtan
Copy link
Contributor Author

wmtan commented Mar 6, 2015

The test error has nothing whatever to do with this PR

@ktf
Copy link
Contributor

ktf commented Mar 6, 2015

Indeed the file seems MIA. We should probably merge this.

On 6 Mar 2015, at 7:10, wmtan wrote:

The test error has nothing whatever to do with this PR


Reply to this email directly or view it on GitHub:
#8106 (comment)

@slava77
Copy link
Contributor

slava77 commented Mar 6, 2015

+1

for #8106 c5b318d
this is the same commit as in #8107 ; I double-checked that there are no differences in the jenkins comparisons (fwlite and DQM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants