Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rechitinregions #8109

Merged
merged 1 commit into from Mar 6, 2015

Conversation

matteosan1
Copy link
Contributor

The filter produces a collection of hits within L1 seeded regions. With the old implementation if a hit was belonging to more than 1 region it was added multiple times in the collection. Given the size of the L1 regions the overlap is mainly reduced to their boundaries so the artificial increase of energy is observed in the PFClusters used to compute Ecal Isolation rather than in SuperClusters (checked to be ~the same).

Compared online and offline Sum(PFClusters_Et) around HLT candidates (in dr<0.3). The fraction of events in Zee with (E_online-E_offline)/E_offline > 15% is:
with bug 8%;
with bug-fix ~1%.

The bug is affecting just HLT reconstruction, the filter is not used anywhere else.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_5_X.

fix rechitinregions

It involves the following packages:

RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

@matteosan1
Please make a backport PR for 74X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants