New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rechitinregions #8109
fix rechitinregions #8109
Conversation
A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_5_X. fix rechitinregions It involves the following packages: RecoEgamma/EgammaHLTProducers @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks. |
@matteosan1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
The filter produces a collection of hits within L1 seeded regions. With the old implementation if a hit was belonging to more than 1 region it was added multiple times in the collection. Given the size of the L1 regions the overlap is mainly reduced to their boundaries so the artificial increase of energy is observed in the PFClusters used to compute Ecal Isolation rather than in SuperClusters (checked to be ~the same).
Compared online and offline Sum(PFClusters_Et) around HLT candidates (in dr<0.3). The fraction of events in Zee with (E_online-E_offline)/E_offline > 15% is:
with bug 8%;
with bug-fix ~1%.
The bug is affecting just HLT reconstruction, the filter is not used anywhere else.