Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate HcalCaloFlagLabels from RecoLocalCalo/HcalRecAlgos to DataFormats/METReco (same as #8114) #8115

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Mar 6, 2015

  • HcalCaloFlagLabels are moved to DataFormats/METReco
  • HcalCaloFlagTool is split off into DataFormats/METReco/interface/HcalCaloFlagTool, since it's rarely used

This removes dependence of DF on Reco

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2015

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

relocate HcalCaloFlagLabels from RecoLocalCalo/HcalRecAlgos to DataFormats/METReco (same as #8114)

It involves the following packages:

DQM/HcalMonitorTasks
DataFormats/METReco
RecoEgamma/EgammaHFProducers
RecoJets/JetAnalyzers
RecoJets/JetProducers
RecoLocalCalo/CastorReco
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoMET/METProducers
RecoParticleFlow/PFClusterProducer

@nclopezo, @cvuosalo, @slava77, @cmsbuild, @deguio, @danduggan can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @ahinzmann, @mmarionncern, @lgray, @jdolen, @nhanvtran, @bachtis, @yslai, @schoef, @mariadalfonso, @argiro, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Mar 6, 2015

+1

for #8115 8eafdb8
this is the same code change as in #8114 8eafdb8
based on tests #8114

@deguio
Copy link
Contributor

deguio commented Mar 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

@cmsbuild, please test
(maybe the tests are stuck @nclopezo )

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 8, 2015
…-DFMet-dep

 relocate HcalCaloFlagLabels from RecoLocalCalo/HcalRecAlgos to DataFormats/METReco (same as #8114)
@davidlange6 davidlange6 merged commit ec6b832 into cms-sw:CMSSW_7_5_X Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants