adding puppi to miniAODs #8122
adding puppi to miniAODs #8122
Conversation
|
A new Pull Request was created by @jshlee (Jason Lee) for CMSSW_7_5_X. adding puppi to miniAODs It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
|
I'm testing the size effect adding @gpetruc |
|
|
||
| addJetCollection(process, postfix = "", labelName = 'Puppi', jetSource = cms.InputTag('ak4PFJetsPuppi'), | ||
| jetCorrections = ('AK4PF', ['L1FastJet', 'L2Relative', 'L3Absolute'], ''), | ||
| algo= 'AK', rParam = 0.4) |
There was a problem hiding this comment.
b-tagging should be enabled here
|
added b-tagging and merged with #8132 on https://github.com/arizzi/cmssw/tree/miniAOD-pvassociation-packedsorting-puppi now testing overall size |
| @@ -268,6 +268,8 @@ bool pat::PackedCandidate::longLived() const {return false;} | |||
|
|
|||
| bool pat::PackedCandidate::massConstraint() const {return false;} | |||
|
|
|||
| // puppiweight | |||
| void pat::PackedCandidate::setPuppiWeight(float p) { packedPuppiweight_ = pack8log(p,-2,0);} | |||
There was a problem hiding this comment.
how about making it symmetric in -1,1 instead? so that it has higher precision near zero too?
pack8log( (p-0.5)*2,-2,0,64)
where the last argument (64) is needed if you want to take the same space as it is doing now with 7+1 signed bits (i.e. one is never used)
|
concerning the daughters of jets ideally one should create the value map |
|
here some size estimate including also #8132 (and fixing the conflicts) we still miss the daughter vector to be properly rekeyed (it should take another ~200-300 bytes/event) |
|
-1 |
added puppi jet collection and puppi met into miniAODs
added jet charge, btagging, secondary vertex info and daughter links for puppi jets
added puppi weights as packed 8 bit into packcandidates
removed labels in puppi producer since only three different types of objects are produced
fixed the packing for liblogintpack, negative values were being lost
updated PackedCandidate ClassVersion to 17
added new iputs to PATPackedCandidateProducer, (PuppiWeight, PuppiCandsMap and PuppiCands) to save puppi weights into packcandidates and ValueMap for puppi to be able to map back to the puppi candidates from puppi jets to packcandidates