Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIAOD: sorting of packedPFcandidates and PV association information - 74X same as #8132 #8133

Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Mar 7, 2015

The information about which PV is matched to a candidate is added and the existing bits (fromPV) used for different definitions of CHS are improved to carry more information and allow change-of-PV from miniAOD.

In addition a sorting of the candidates is provided to improve the zlib compression (put similar things sequentially).

Unused ifdef'ed code is also removed.

Overall, this PR reduces the miniaod size by 2Kb/ev.
http://arizzi.web.cern.ch/arizzi/3bits.html (this PR)
vs
http://arizzi.web.cern.ch/arizzi/refib.html (original)

Legacy behaviour of PackedCandidate::fromPV() is implemented and gives 99.95% the same result (remaining difference can probably be fixed, if needed, by further tuning the accessor)

74X version of #8132

@gpetruc

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2015

A new Pull Request was created by @arizzi for CMSSW_7_4_X.

MINIAOD: sorting of packedPFcandidates and PV association information - 74X same as #8132

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

Pull request #8133 was updated. @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2015

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@arizzi
Copy link
Contributor Author

arizzi commented Mar 11, 2015

can this be merged? (as it twin #8132 was)

@arizzi
Copy link
Contributor Author

arizzi commented Mar 11, 2015

@davidlange6 can we get in sync with 75X? otherwise it is a mess to keep new PRs in sync..

@davidlange6
Copy link
Contributor

@arizzi - would be better to develop in 75x and then port in chunks... 74x will tend to be behind 75x.

@davidlange6
Copy link
Contributor

+1

@arizzi
Copy link
Contributor Author

arizzi commented Mar 12, 2015

this PR is already integrated in 75X... other people are developing on 74X

@arizzi arizzi closed this Mar 12, 2015
@arizzi arizzi reopened this Mar 12, 2015
@arizzi
Copy link
Contributor Author

arizzi commented Mar 12, 2015

(closed by mistake)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants