New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIAOD: sorting of packedPFcandidates and PV association information - 74X same as #8132 #8133
MINIAOD: sorting of packedPFcandidates and PV association information - 74X same as #8132 #8133
Conversation
A new Pull Request was created by @arizzi for CMSSW_7_4_X. MINIAOD: sorting of packedPFcandidates and PV association information - 74X same as #8132 It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
can this be merged? (as it twin #8132 was) |
@davidlange6 can we get in sync with 75X? otherwise it is a mess to keep new PRs in sync.. |
@arizzi - would be better to develop in 75x and then port in chunks... 74x will tend to be behind 75x. |
+1 |
this PR is already integrated in 75X... other people are developing on 74X |
(closed by mistake) |
MINIAOD: sorting of packedPFcandidates and PV association information - 74X same as #8132
…, since it had been broken by mistake in cms-sw#8133)
The information about which PV is matched to a candidate is added and the existing bits (fromPV) used for different definitions of CHS are improved to carry more information and allow change-of-PV from miniAOD.
In addition a sorting of the candidates is provided to improve the zlib compression (put similar things sequentially).
Unused ifdef'ed code is also removed.
Overall, this PR reduces the miniaod size by 2Kb/ev.
http://arizzi.web.cern.ch/arizzi/3bits.html (this PR)
vs
http://arizzi.web.cern.ch/arizzi/refib.html (original)
Legacy behaviour of PackedCandidate::fromPV() is implemented and gives 99.95% the same result (remaining difference can probably be fixed, if needed, by further tuning the accessor)
74X version of #8132
@gpetruc