Add new ROOT6 checksum to XML spec #8139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_4_X. Add new ROOT6 checksum to XML spec It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
davidlange6
added a commit
that referenced
this pull request
Mar 9, 2015
Add new ROOT6 checksum to XML spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid version clashes that can cause fatal run-time errors, the ROOT6 versions for classes need to be specified in the ROOT5 spec files (with the correct checksums). This prevents adding a new version in ROOT 5 where the version number conflicts with a ROOT6 version.
One class, pat::PackedGenParticle, has a new class version in ROOT6. This pull request simply adds it to the ROOT5 spec file. Neither the ROOT5 version or checksum is changed.