Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move string operations to get module labels to bookHistograms method #8189

Merged
merged 2 commits into from Mar 13, 2015

Conversation

puigh
Copy link
Contributor

@puigh puigh commented Mar 11, 2015

Removed moduleLabels call from HLTConfigProvider in fillHltMatrix method, which is called for every event. List of modules per path set in bookHistograms method done at the beginRun as HLT configuration is guaranteed not to change during a run.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @puigh for CMSSW_7_5_X.

Move string operations to get module labels to bookHistograms method

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @abbiendi, @trocino, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Mar 11, 2015

ciao @puigh
the initialization of the HLTConfigProvider should be done inside the dqmBeginRun method. everything which is runBased and differs from the actual histo booking should be moved there as explained in:
https://twiki.cern.ch/twiki/bin/viewauth/CMS/ThreadedDQM

could you please take care of fixing this?
ciao and thanks,
F.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 13, 2015

+1
@puigh yes it does.
thanks,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants