Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmic muon validation #8199

Merged
merged 4 commits into from Mar 20, 2015
Merged

Conversation

abbiendi
Copy link
Contributor

This PR adds a complete validation of muon tracks for cosmics reco plus a few fixes to the general muon validation.

For cosmics an equivalent code has been used to obtain the validation plots attached to the PR #7044 #7044

The cosmics validation sequence could be used to implement a standard validation on cosmics processes in runTheMatrix (7.0, 1307.0 - this is left open)

Backport to 74X (straightforward) should follow this PR

Some details:

  • for cosmics validation some changes to common tools with TRK are necessary. This does not break anything as currently there is no validation for cosmics in CMSSW.
  • some fixes to muon validation has been added:
  • validation plots of reco quantities only for signal-matched muons (useful to remove contamination from PU to the interesting quantities, and to validate samples produced with premixing)
  • technical improvements (still only a first set, more to come) reducing the cpu footprint of muon validation
  • fix the indentation in MuonTrackValidator (broken since 620 !)
  • minor fixes to log messages

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abbiendi for CMSSW_7_5_X.

Cosmic muon validation

It involves the following packages:

CommonTools/RecoAlgos
SimMuon/MCTruth
SimTracker/TrackAssociation
Validation/RecoMuon

@civanch, @nclopezo, @cvuosalo, @mdhildreth, @cmsbuild, @deguio, @slava77, @danduggan can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @battibass, @makortel, @threus, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @ahinzmann, @cerati, @venturia, @trocino, @dgulhan, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 11, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants