Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINIAOD: reducing packedMETunceratinty to float16 on top of 8159 #8208

Merged
merged 1 commit into from Mar 17, 2015
Merged

MINIAOD: reducing packedMETunceratinty to float16 on top of 8159 #8208

merged 1 commit into from Mar 17, 2015

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Mar 11, 2015

This uses float16 in pat::MET::PackedMETUnceratinty and saves about 100bytes per MET per Event.

With PUPPI PR #8122 the total saving is 200bytes/Event

This PR is on top of #8159 @gpetruc

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Mar 11, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_7_4_X.

MINIAOD: reducing packedMETunceratinty to float16 on top of 8159

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: 3505a6a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8208/7009/summary.html

@cmsbuild
Copy link
Contributor

+1
Tested at: 3505a6a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8208/3485/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8208/3485/summary.html

@arizzi
Copy link
Contributor Author

arizzi commented Mar 17, 2015

given that #8159 is now merged, it would be good to merge this too... @monttj can you please sign?

@arizzi arizzi mentioned this pull request Mar 17, 2015
Merged
@davidlange6
Copy link
Contributor

@arizzi - github says that this PR does not merge.

@arizzi
Copy link
Contributor Author

arizzi commented Mar 17, 2015

rebasing it

@arizzi arizzi force-pushed the from-CMSSW_7_4_0_pre8_plus8159_Float16Uncert branch from 3505a6a to bc668d8 Compare March 17, 2015 15:38
@arizzi
Copy link
Contributor Author

arizzi commented Mar 17, 2015

@davidlange6 should be ok now

@cmsbuild
Copy link
Contributor

Pull request #8208 was updated. @cmsbuild, @vadler, @nclopezo, @monttj can you please check and sign again.

davidlange6 added a commit that referenced this pull request Mar 17, 2015
@davidlange6
Merge pull request #8208 from arizzi/from-CMSSW_7_4_0_pre8_plus8159_F…
aae7d22 
…loat16Uncert

MINIAOD: reducing packedMETunceratinty to float16 on top of 8159
@davidlange6 davidlange6 merged commit aae7d22 into cms-sw:CMSSW_7_4_X Mar 17, 2015
@cmsbuild
Copy link
Contributor

+1
Tested at: bc668d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8208/6717/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8208/6717/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arizzi @cmsbuild @davidlange6