New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit dependency on CGAL library to RecoHI/HiJetAlgos plugin #8215
Conversation
The CGAL library causes problems with valgrind therefore we want to limit its exposure. Moving the dependency out of RecoHI/HiJetAlgos avoids having other libraries with link to that one having unneeded dependencies to CGAL. The only module which actually needs to link to CGAL is VoronoiBackgroundProducer.
This should allow valgrind to function again for non HI jobs. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X. Limit dependency on CGAL library to RecoHI/HiJetAlgos plugin It involves the following packages: RecoHI/HiJetAlgos @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Limit dependency on CGAL library to RecoHI/HiJetAlgos plugin
The CGAL library causes problems with valgrind therefore we want to
limit its exposure. Moving the dependency out of RecoHI/HiJetAlgos
avoids having other libraries with link to that one having unneeded
dependencies to CGAL. The only module which actually needs to link
to CGAL is VoronoiBackgroundProducer.