Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit dependency on CGAL library to RecoHI/HiJetAlgos plugin #8215

Merged
merged 2 commits into from Mar 13, 2015

Conversation

Dr15Jones
Copy link
Contributor

The CGAL library causes problems with valgrind therefore we want to
limit its exposure. Moving the dependency out of RecoHI/HiJetAlgos
avoids having other libraries with link to that one having unneeded
dependencies to CGAL. The only module which actually needs to link
to CGAL is VoronoiBackgroundProducer.

The CGAL library causes problems with valgrind therefore we want to
limit its exposure. Moving the dependency out of RecoHI/HiJetAlgos
avoids having other libraries with link to that one having unneeded
dependencies to CGAL. The only module which actually needs to link
to CGAL is VoronoiBackgroundProducer.
@Dr15Jones
Copy link
Contributor Author

This should allow valgrind to function again for non HI jobs.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Limit dependency on CGAL library to RecoHI/HiJetAlgos plugin

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @richard-cms, @appeltel, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cvuosalo
Copy link
Contributor

+1

For #8215 dc8d983

This PR makes changes in compiling and linking to reduce dependence on the CGAL library. It should not affect program outputs or physics quantities.

The Jenkins tests are OK and show no differences from the baseline.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants