Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix and check on empty DQM content #8251

Merged
merged 1 commit into from Mar 16, 2015
Merged

bugfix and check on empty DQM content #8251

merged 1 commit into from Mar 16, 2015

Conversation

threus
Copy link
Contributor

@threus threus commented Mar 13, 2015

Fixing the Strip bad component calibration, to be used at PCL. Added protection against running the calibration on empty DQM file (i.e. when Strips are out of DAQ). Work of @suchandradutta and Sourav Dey.

We would like to use this update at PCL for CRAFT already.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @threus for CMSSW_7_3_X.

bugfix and check on empty DQM content

It involves the following packages:

DQMOffline/CalibTracker

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Mar 13, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: a09275e
When I ran the RelVals I found an error in the following worklfows:
50101.0 step2

runTheMatrix-results/50101.0_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS/step2_SingleMuPt10_UP15ID+SingleMuPt10_UP15FSIDINPUT+SingleMuPt10FS_UP15_ID+HARVESTUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8251/6590/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Mar 16, 2015
bugfix and check on empty DQM content
@davidlange6 davidlange6 merged commit 60b06e8 into cms-sw:CMSSW_7_3_X Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants