Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GainCalibration #8255

Merged
merged 4 commits into from Mar 26, 2015
Merged

Conversation

quertenmont
Copy link
Contributor

This was previously called "FixForClusters", but for unknown reason gitHub was not updating the PR8144 with my new push.
(I closed it and made a new PR here)

Nothing striking in these changes...
Most is cleaning up and update for cruzet15 data analysis and run2 preparation

Loic

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @quertenmont (Loic Quertenmont) for CMSSW_7_5_X.

Fixes for GainCalibration

It involves the following packages:

CalibTracker/SiStripChannelGain
CalibTracker/SiStripCommon
CalibTracker/SiStripHitEfficiency

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@jlagram, @gbenelli, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Mar 14, 2015

@nclopezo
I see that the comparison results are "queued". This means that the bot is executing them, right?

@nclopezo
Copy link
Contributor

@diguida
Hi Salvatore, the workflow 401.0 is failing in the IBs. So the baseline cannot be generated. I queued the tests for this PR with CMSSW_7_5_X_2015-03-12-0200 to be able to get a comparison.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@quertenmont
Copy link
Contributor Author

Hi all,

Can we please sign and close this PR ?

Loic

@diguida
Copy link
Contributor

diguida commented Mar 23, 2015

@quertenmont
I was giving a look to it last week, then we had a huge queue.
Looking into it

@diguida
Copy link
Contributor

diguida commented Mar 24, 2015

+1
@quertenmont the static analyser reports some issue: I will give you the pointers in the code

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants