Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiThreading of HLTcore plugins #8270

Merged
merged 2 commits into from Mar 20, 2015
Merged

MultiThreading of HLTcore plugins #8270

merged 2 commits into from Mar 20, 2015

Conversation

Martin-Grunewald
Copy link
Contributor

MultiThreading of HLTcore plugins

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Mar 13, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_4_X.

MultiThreading of HLTcore plugins

It involves the following packages:

HLTrigger/Configuration
HLTrigger/HLTcore

@Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please review it and eventually sign? Thanks.
@geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

fwyzard
fwyzard reviewed Mar 13, 2015
View reviewed changes
HLTrigger/HLTcore/interface/TriggerSummaryProducerAOD.h
}
};

struct GlobalTags {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Martin,
may I suggest a different name, to avoid confusion with the "GlobalTag" for conditions ?

@Dr15Jones
Copy link
Contributor

Looks good to me.

@Martin-Grunewald
Copy link
Contributor Author

Thanks for the comments - implemented with the recent commit to the PR.

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #8270 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @nclopezo, @fwyzard can you please check and sign again.

@Martin-Grunewald Martin-Grunewald mentioned this pull request Mar 13, 2015
Merged
@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

+1
Tested at: ceeb312
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8270/3488/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8270/3488/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 20, 2015
@cmsbuild
Merge pull request #8270 from Martin-Grunewald/MultiThreadingHLTcore74X
76380aa 
MultiThreading of HLTcore plugins
@cmsbuild cmsbuild merged commit 76380aa into cms-sw:CMSSW_7_4_X Mar 20, 2015
@Martin-Grunewald Martin-Grunewald deleted the MultiThreadingHLTcore74X branch March 21, 2015 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Martin-Grunewald @cmsbuild @Dr15Jones @davidlange6 @fwyzard