Geant4e test example

[lviliani]

An example including the basic functions to refit tracks with Geant4e has been added.

[cmsbuild]

A new Pull Request was created by @lviliani (Lorenzo Viliani) for CMSSW_7_5_X.

Geant4e test example

It involves the following packages:

TrackPropagation/Geant4e

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[civanch]

@lviliani , usually all test macro are in test sub-directory. Why in this case they are in doc? It is minor thing but I am confused.

[Dr15Jones]

Is the Geant4e code thread safe?

[lviliani]

@civanch , in the old Geant4e package the test example was in that sub-directory. That's why I put it there. Anyway it can be also moved in the test sub-directory.

[VinInn]

The assignment of this package is wrong...
this is reco not sim!

[civanch]

@Dr15Jones , the main parts of Geant4e (EM physics and navigation) are thread safe. Thread safety of Geant4e implementation within this package was not validated - the plan was first restore functionality in sequential mode. Probably, optimal will be to make an alternative plugin working in MT mode as we did for OscarProducer.

@VinInn, concerning package assignment: I fully agree that even depending on G4 it is RECO as other TrackPropagation sub-packages.

@lviliani , I would move all three python files from doc to test for consistency.

[cmsbuild]

+1
Tested at: 2ad80af
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8273/6980/summary.html

[civanch]

+1

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[davidlange6]

@nclopezo - seems the tests are stuck. Could you have a look

[nclopezo]

Hi, they are in the queue, the queue is a bit full, they should start later during the afternoon.

[davidlange6]

Thanks!

On Mar 16, 2015, at 4:19 PM, David Mendez notifications@github.com wrote:

Hi, they are in the queue, the queue is a bit full, they should start later during the afternoon.

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

+1
Tested at: 6d5389c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8273/3518/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8273/3518/summary.html