StoppedParticles Bug Fix

[jalimena]

The purpose of this PR is to:

• Fix a bug for the StoppedParticles created in the RHStopTracer. Before, the tracks coming from the antiparticles were not looked at, to see if the antiparticles stop in the detector. This is fixed with the one line change in Exotica_HSCP_SIM_cfi.py.
• To better debug this type of problem in the future, more debug statements were added to RHStopTracer.

[cmsbuild]

A new Pull Request was created by @jalimena (Juliette Alimena) for CMSSW_7_5_X.

StoppedParticles Bug Fix

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[civanch]

@jalimena , is it possible to substitute std::cout by LogVerbatum() ?
Also I am not sure if it is optimal to identify particles by name and not pdg code.

[jalimena]

The couts are within the if(mDebug) statement, but if you prefer for me to change this to LogVerbatum() or LogDebug(), I can do that.

Identifying the particles by pdg code would be nice, although I'm not sure how practical it is, given that some of the models considered make RHadrons and thus a fairly long list of particles are considered. What I did was to fix the code in the same way it was written, in order to make it work for the antiparticles. However, I can try to change the code to identify them by pdgId, if that's best.

Let me know.

[cmsbuild]

+1
Tested at: 86e1203
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8282/4728/summary.html

[civanch]

@jalimena , let us substitute std::cout in this PR, this does not require any rethinking on the code. Method of particle identification can be updated next time if a good solution will be proposed.

[jalimena]

Ok sounds good, done. Thanks!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[cmsbuild]

+1
Tested at: e8544ba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8282/6672/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8282/6672/summary.html