Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling TFormula::SetName leads to thread safety issues #8289

Conversation

Dr15Jones
Copy link
Contributor

When a TFormula is created, it may be added to a global list of formulas.
If that happens, then calling TFormula::SetName at the same time another
thread is looping through the list of formulas can lead to a crash.
Setting the name correctly in the constructor avoids the problem.
This problem was found by helgrind.

When a TFormula is created, it may be added to a global list of formulas.
If that happens, then calling TFormula::SetName at the same time another
thread is looping through the list of formulas can lead to a crash.
Setting the name correctly in the constructor avoids the problem.
This problem was found by helgrind.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Calling TFormula::SetName leads to thread safety issues

It involves the following packages:

RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 15, 2015
…iplexerThreadSafety

Calling TFormula::SetName leads to thread safety issues
@cmsbuild cmsbuild merged commit f50c43a into cms-sw:CMSSW_7_4_X Mar 15, 2015
@Dr15Jones Dr15Jones deleted the fixRecoTauDiscriminantCutMultiplexerThreadSafety branch April 7, 2015 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants