Calling TFormula::SetName leads to thread safety issues #8289
Conversation
When a TFormula is created, it may be added to a global list of formulas. If that happens, then calling TFormula::SetName at the same time another thread is looping through the list of formulas can lead to a crash. Setting the name correctly in the constructor avoids the problem. This problem was found by helgrind.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X. Calling TFormula::SetName leads to thread safety issues It involves the following packages: RecoTauTag/RecoTau @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
|
Please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
|
+1 |
…iplexerThreadSafety Calling TFormula::SetName leads to thread safety issues
When a TFormula is created, it may be added to a global list of formulas.
If that happens, then calling TFormula::SetName at the same time another
thread is looping through the list of formulas can lead to a crash.
Setting the name correctly in the constructor avoids the problem.
This problem was found by helgrind.