Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest calibrations from Pedro + global compensation plugin #8305

Merged
merged 2 commits into from Mar 17, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Mar 15, 2015

  • Update to HGCal Calibrations with better pi/e determination
  • Improved new global hadron compensation plugin for PandoraPFA

@pfs @vandreev11 @sethzenz @kpedro88

@lgray
Copy link
Contributor Author

lgray commented Mar 15, 2015

@mark-grimes We are waiting on some final checks in 140PU to make sure everything is OK. We'll update here with if this is necessary for the release or not.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

latest calibrations from Pedro + global compensation plugin

It involves the following packages:

RecoParticleFlow/PandoraTranslator

The following packages do not have a category, yet:

RecoParticleFlow/PandoraTranslator

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor Author

lgray commented Mar 16, 2015

@mark-grimes got the OK-to-go from @pfs, please integrate this and cut the release.

@vandreev11

@mark-grimes
Copy link

Okay. @fratnikov is looking after integration at the moment so he'll take care of it when he comes online around now.

@fratnikov, the release will also need the other things in the queue. A patch release is probably enough (changing the Pandora external again would have required a full release).

@lgray
Copy link
Contributor Author

lgray commented Mar 16, 2015

@mark-grimes @fratnikov There will be one more PR. Just a moment.

@lgray
Copy link
Contributor Author

lgray commented Mar 16, 2015

@mark-grimes actually let me add it here...

@lgray
Copy link
Contributor Author

lgray commented Mar 16, 2015

@mark-grimes @fratnikov done, please use this.

@cmsbuild
Copy link
Contributor

Pull request #8305 was updated. @cmsbuild, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #8305 was updated. @cmsbuild, @nclopezo can you please check and sign again.

@fratnikov
Copy link

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@fratnikov
Copy link

merge
tested also with 15661 and 15861

cmsbuild added a commit that referenced this pull request Mar 17, 2015
latest calibrations from Pedro + global compensation plugin
@cmsbuild cmsbuild merged commit b317419 into cms-sw:CMSSW_6_2_X_SLHC Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants