Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std:: qualifiers or directives #833

Merged
merged 1 commit into from Sep 14, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 14, 2013

When adding missing std:: qualifiers, I missed this one package, CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos.

Without this change, this package and one other package will not compile against ROOT6.

The signature can be bypassed.

Tested with checkdeps -a and runTheMatrix.py -s.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Add std:: qualifiers or directives

It involves the following packages:

CalibCalorimetry/EcalCorrelatedNoiseAnalysisAlgos

@demattia, @rcastello can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

ktf added a commit that referenced this pull request Sep 14, 2013
@ktf ktf merged commit 6c42086 into cms-sw:CMSSW_7_0_X Sep 14, 2013
@wmtan wmtan deleted the AddStdQualifierOrDirective branch September 17, 2013 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants