HF shower library interface vers03 #8358
Conversation
| << "," << cos(momDir.phi()) << ", " << sin(momDir.theta()) | ||
| << "," << cos(momDir.theta()); | ||
| #endif | ||
|
|
||
| std::vector<HFShowerLibrary::Hit> hit; | ||
| ok = false; | ||
| if (parCode == pi0PDG || parCode == etaPDG || parCode == nuePDG || |
There was a problem hiding this comment.
move the parCode condition to the fillHits function,
this allows you to remove the parCode condition from
FastHFShowerLibrary
There was a problem hiding this comment.
The code for particles in FullSim is initiated with initRun(G4ParticleTable * theParticleTable) function,
so for FastSim need to write some interface for this case.
There was a problem hiding this comment.
right.
@civanch, can we give the *PDG variabels proper values inside the constructor of HFShowerLibrary?
There was a problem hiding this comment.
|
A new Pull Request was created by @lveldere for CMSSW_7_5_X. HF shower library interface vers03 It involves the following packages: FastSimulation/Calorimetry @ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. |
|
|
||
| protected: | ||
| std::vector<HFShowerLibrary::Hit> getHits(G4ThreeVector & p, G4ThreeVector & v, |
There was a problem hiding this comment.
when you move the parCode condition into HFShowerLibrary::fillHits,
the parcode condition can be removed from FastHFShowerLibrary::getHits.
The 2 remaining lines of code inside this function better move to FastHFShowerLibrary::recoHFShowerLibrary, so that this function can be removed.
There was a problem hiding this comment.
Yes. it is possible to remove FastHFShowerLibrary::getHits function
|
Hi Vladimir Vladimir Andreev has implemented such that for run1 we use GFLASH, as Lukas On Tue, Mar 17, 2015 at 7:39 PM, Vladimir Ivantchenko <
|
|
Comparison is ready |
|
moves to #8591 |
I open this pr to enable a discussion.
A proper description will follow later.