Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL Cosmics reco configuration update for 74X #8376

Merged
merged 1 commit into from Mar 18, 2015

Conversation

abdoulline
Copy link

This is to replace the default Method 2 (which may not work for out-of-time signals) with "classical" Method 0, for which the range of TS used is maximally expanded.
For CRAFT and Splashes data in particular, and for Cosmics data in general.
Identical to #8375 submitted to 73X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline for CMSSW_7_4_X.

HCAL Cosmics reco configuration update for 74X

It involves the following packages:

RecoLocalCalo/Configuration

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 18, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 18, 2015

+1

for #8376 46b4e12
the same code changes were tested and signed off for 73X in #8375

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@abdoulline abdoulline deleted the Cosmics_HCAL_custom_74X branch March 19, 2015 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants