Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix usage of SeedFromConsecutiveHitsCreator w/in SeedGeneratorFromProtoTracksEDProducer #8379

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Mar 18, 2015

same as #8378
but for 75X

@mtosi
Copy link
Contributor Author

mtosi commented Mar 18, 2015

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_5_X.

fix usage of SeedFromConsecutiveHitsCreator w/in SeedGeneratorFromProtoTracksEDProducer

It involves the following packages:

RecoTracker/TkSeedGenerator

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #8379 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

Please close this PR : it conflicts with #7781 and is superseeded by #8393

@slava77
Copy link
Contributor

slava77 commented Mar 19, 2015

-1
superseded by #8393

@cmsbuild
Copy link
Contributor

-1
Tested at: e25e416
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8379/3609/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants