Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiny xml for rivet #838

Merged
merged 1 commit into from Sep 21, 2013
Merged

Fix tiny xml for rivet #838

merged 1 commit into from Sep 21, 2013

Conversation

lenzip
Copy link
Contributor

@lenzip lenzip commented Sep 16, 2013

Removed file GeneratorInterface/RivetInterface/plugins/tinyxml.h because a different version is available in FWCore/Utilities/interface/tinyxml.h. Now the latter is used

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lenzip for CMSSW_6_2_X.

Fix tiny xml for rivet

It involves the following packages:

GeneratorInterface/RivetInterface

@vciulli can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlt you are the release manager for this.

@vciulli
Copy link
Contributor

vciulli commented Sep 17, 2013

+1

On Sep 16, 2013, at 10:32, cmsbuild wrote:

A new Pull Request was created by @lenzip for CMSSW_6_2_X.

Fix tiny xml for rivet

It involves the following packages:

GeneratorInterface/RivetInterface

@vciulli can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlt you are the release manager for this.


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @davidlt can you please take care of it?

@fabiocos
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Sep 21, 2013
Misc cleanup -- Fix tinyxml for rivet
@ktf ktf merged commit 4715586 into cms-sw:CMSSW_6_2_X Sep 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants