Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to checksums of simple LHE files + remove whatever fake blank spaces/tabs were created by some editor #8415

Merged
merged 1 commit into from Mar 24, 2015

Conversation

covarell
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_7_4_X.

fix to checksums of simple LHE files + remove whatever fake blank spaces/tabs were created by some editor

It involves the following packages:

GeneratorInterface/LHEInterface

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

This should go in 75x no?

@covarell
Copy link
Contributor Author

Also did the PR for 75x (#8418), if possible it should be backported to 74x I believe (this is independent of any other cmssw code, so ideally it should be available to users in the maximum number of releases)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@covarell
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 24, 2015
fix to checksums of simple LHE files + remove whatever fake blank spaces/tabs were created by some editor
@cmsbuild cmsbuild merged commit 6cd528f into cms-sw:CMSSW_7_4_X Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants