New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiChainEvent: don't throw in getByProductID #8423
MultiChainEvent: don't throw in getByProductID #8423
Conversation
The behaviour before this fix causes an exception to be thrown when using ref.isAvailable() if the product is missing in both the primary and the secondary file. This bugfix is already present in 7_3_X and later, see cms-sw@87d13c0#diff-a7cf5650266eb5357959bebb6fd57f82
A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_2_X. MultiChainEvent: don't throw in getByProductID It involves the following packages: DataFormats/FWLite @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
Please also make a pull request with this change for CMSSW_7_4_X. This will then go into 7_5 since we are still auto-merging those two. |
Hi Chris, The problem is there only in 72X (and possibly earlier).
Il 20-mar-2015 09:23 "Chris Jones" notifications@github.com ha scritto:
|
+1 |
Thanks for pointing out it was fixed in later versions. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
…_72X MultiChainEvent: don't throw in getByProductID
The behaviour before this fix causes an exception to be thrown
when using ref.isAvailable() if the product is missing in both
the primary and the secondary file.
This bugfix is already present in 7_3_X and later, see
87d13c0#diff-a7cf5650266eb5357959bebb6fd57f82