Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiChainEvent: don't throw in getByProductID #8423

Merged

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Mar 19, 2015

The behaviour before this fix causes an exception to be thrown
when using ref.isAvailable() if the product is missing in both
the primary and the secondary file.

This bugfix is already present in 7_3_X and later, see
87d13c0#diff-a7cf5650266eb5357959bebb6fd57f82

The behaviour before this fix causes an exception to be thrown
when using ref.isAvailable() if the product is missing in both
the primary and the secondary file.
This bugfix is already present in 7_3_X and later, see
cms-sw@87d13c0#diff-a7cf5650266eb5357959bebb6fd57f82
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_2_X.

MultiChainEvent: don't throw in getByProductID

It involves the following packages:

DataFormats/FWLite

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Please also make a pull request with this change for CMSSW_7_4_X. This will then go into 7_5 since we are still auto-merging those two.

@gpetruc
Copy link
Contributor Author

gpetruc commented Mar 20, 2015

Hi Chris,

The problem is there only in 72X (and possibly earlier).
In new releases it was fixed when thinned collections were introduced.

Giovanni

Il 20-mar-2015 09:23 "Chris Jones" notifications@github.com ha scritto:

Please also make a pull request with this change for CMSSW_7_4_X. This
will then go into 7_5 since we are still auto-merging those two.


Reply to this email directly or view it on GitHub
#8423 (comment).

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

Thanks for pointing out it was fixed in later versions.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants