Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic Fit for HCAL - HLT #8434

Merged
merged 16 commits into from Mar 31, 2015
Merged

Conversation

sabrandt
Copy link
Contributor

Adding deterministic fit option to the HCAL reconstruction algorithms, for HLT testing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sabrandt (Stephanie Brandt) for CMSSW_7_4_X.

Deterministic Fit for HCAL - HLT

It involves the following packages:

CalibCalorimetry/HcalAlgos
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers

@nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Mar 26, 2015

+1

for #8434 f3e1247
in addition to jenkins tests, also tested locally in CMSSW_7_4_0_pre9 /test area sign532/.
Current settings don't change the RECO or HLT performance.

A few plots comparing performance of M3 and M2 are posted above for a reference.

@davidlange6
Copy link
Contributor

@diguida, any issues with this PR?

@mmusich
Copy link
Contributor

mmusich commented Mar 31, 2015

+1
changes in CalibCalorimetry/HcalAlgos/

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants