Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 2 format of PCC ntupler - version 1 #8446

Merged
merged 3 commits into from Mar 25, 2015

Conversation

capalmer85
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @capalmer85 for CMSSW_5_3_X.

Run 2 format of PCC ntupler - version 1

It involves the following packages:

RecoLuminosity/LumiProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2015

Hi Chris,

Why is the run2 development going to 53X release?

@capalmer85
Copy link
Contributor Author

Hi Slava,

It was validated on 8 TeV data to give the same results at the previous
version. I wanted them both to be in some official place, then port to
74X. This is what I said I was going to do in 6962.

Is this alright?

Cheers,
Chris

On Sat, Mar 21, 2015 at 3:58 AM, Slava Krutelyov notifications@github.com
wrote:

Hi Chris,

Why is the run2 development going to 53X release?


Reply to this email directly or view it on GitHub
#8446 (comment).

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2015

The 53X is on a monthly (or less frequent) schedule, and this kind of developments will not trigger a new release by themselves.
This needs to be kept in mind for additions to 53X.

@capalmer85
Copy link
Contributor Author

That's ok. As long as it is in the queue, I won't worry about it and move
forward.

Thanks,
Chris

On Mon, Mar 23, 2015 at 4:36 AM, Slava Krutelyov notifications@github.com
wrote:

The 53X is on a monthly (or less frequent) schedule, and this kind of
developments will not trigger a new release by themselves.
This needs to be kept in mind for additions to 53X.


Reply to this email directly or view it on GitHub
#8446 (comment).

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2015

+1

for #8446 f366ce7

changes are in the analysis-level ntuple code in RecoLuminosity/LumiProducer/test/analysis
the code compiles and runs with the provided test config.
Standard workflows are not affected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants