Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically drop LHEXMLStringProduct on input from cmsDriver #8459

Merged
merged 1 commit into from Mar 27, 2015

Conversation

bendavid
Copy link
Contributor

Drops on input automatically the LHEXMLStringProduct whenever the GEN step is run with an input file. (Saves memory which would be used to read the large run product that should only be saved in the initial LHE output step)

Added bonus: ConfigBuilder is now smart enough to simply do nothing in case inputCommands are passed but there is no input file. (May add flexibility in mcm handling of additional inputCommands in the future)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_5_X.

automatically drop LHEXMLStringProduct on input from cmsDriver

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @nclopezo, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost
Copy link

ghost commented Mar 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 40c709f
The relvals timed out after 1 hour.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8459/235/summary.html

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 27, 2015
automatically drop LHEXMLStringProduct on input from cmsDriver
@davidlange6 davidlange6 merged commit 78432ba into cms-sw:CMSSW_7_5_X Mar 27, 2015
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Aug 13, 2015
automatically drop LHEXMLStringProduct on input from cmsDriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants