New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return pointer to streamCache type #848
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X. return pointer to streamCache type It involves the following packages: FWCore/Framework @Dr15Jones, @ktf can you please review it and eventually sign? Thanks. |
Pull request #848 was updated. @Dr15Jones, @ktf can you please check and sign again. |
It should be 'C*' since the module is allowed to modify the object since that object is only accessible in a 'stream' call. |
On 9/16/2013 10:59 AM, Chris Jones wrote:
|
runCache() and luminosityCache() both return C const* |
runCache() and luminosityBlockCache() should return a 'C const*' since multiple threads could access them simultaneously. The StreamCache is only accessible to one thread. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreaded framework -- Return pointer to streamCache type
Small typo found when implementing test classes for edm:global namespace. Returned pointer to Class type T instead of Cache type C. Compared to RunCacheHolder and LuminosityBlockCacheHolder to determine what return type should be.