Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return pointer to streamCache type #848

Merged
merged 1 commit into from Sep 18, 2013
Merged

return pointer to streamCache type #848

merged 1 commit into from Sep 18, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 16, 2013

Small typo found when implementing test classes for edm:global namespace. Returned pointer to Class type T instead of Cache type C. Compared to RunCacheHolder and LuminosityBlockCacheHolder to determine what return type should be.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

return pointer to streamCache type

It involves the following packages:

FWCore/Framework

@Dr15Jones, @ktf can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

Pull request #848 was updated. @Dr15Jones, @ktf can you please check and sign again.

@Dr15Jones
Copy link
Contributor

It should be 'C*' since the module is allowed to modify the object since that object is only accessible in a 'stream' call.

@gartung
Copy link
Member Author

gartung commented Sep 16, 2013

On 9/16/2013 10:59 AM, Chris Jones wrote:

It should be 'C*' since the module is allowed to modify the object
since that object is only accessible in a 'stream' call.


Reply to this email directly or view it on GitHub
#848 (comment).

OK I will back out the second commit.

@gartung
Copy link
Member Author

gartung commented Sep 16, 2013

runCache() and luminosityCache() both return C const*

@Dr15Jones
Copy link
Contributor

runCache() and luminosityBlockCache() should return a 'C const*' since multiple threads could access them simultaneously. The StreamCache is only accessible to one thread.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Sep 18, 2013
Multithreaded framework -- Return pointer to streamCache type
@ktf ktf merged commit f87e325 into cms-sw:CMSSW_7_0_X Sep 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants