Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around bug in ROOT which affects split classes with iorules #8496

Merged

Conversation

Dr15Jones
Copy link
Contributor

If an iorule is attached to a class rather than a builtin type then
if that class is split in the TFile the iorule will not be run. This
change attached the rule to an additional member which is an int.

If an iorule is attached to a class rather than a builtin type then
if that class is split in the TFile the iorule will not be run. This
change attached the rule to an additional member which is an int.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_4_X.

Work around bug in ROOT which affects split classes with iorules

It involves the following packages:

DataFormats/Candidate

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: fdd8500
The relvals timed out after 1 hour.

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8496/6837/summary.html

@slava77
Copy link
Contributor

slava77 commented Mar 25, 2015

+1

for #8496 fdd8500
jenkins tests are ok (nothing is broken)
I didn't try to reproduce the issue fixed by this bugfix

@Dr15Jones
Copy link
Contributor Author

@davidlange6 ping?

davidlange6 added a commit that referenced this pull request Mar 27, 2015
Work around bug in ROOT which affects split classes with iorules
@davidlange6 davidlange6 merged commit 483dc48 into cms-sw:CMSSW_7_4_X Mar 27, 2015
@Dr15Jones Dr15Jones deleted the kludgeAroundROOTSplitIOReadBug branch April 7, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants