Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded InputTag in PATPhotonProducer (same as #7946 , rebased on smth later) #8505

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Mar 24, 2015

(copy-pasting from #7946)

The hardcoded inputtag were preventing the electronVeto in miniAOD to work properly. Different superClusterRefs for (slimmedPhotons and gedGsfElectrons) were indeed compared returning identically false.
Changed accordingly the configuration to produce miniAOD.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_4_X.

Remove hardcoded InputTag in PATPhotonProducer (same as #7946 , rebased on smth later)

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor Author

slava77 commented Mar 24, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 24, 2015
…t7946/pull7946-mo

 Remove hardcoded InputTag in PATPhotonProducer (same as #7946 , rebased on smth later)
@davidlange6 davidlange6 merged commit 1521d70 into cms-sw:CMSSW_7_4_X Mar 24, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants