Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixDQM summary fix in 7_3_X #8514

Merged
merged 2 commits into from Mar 27, 2015
Merged

PixDQM summary fix in 7_3_X #8514

merged 2 commits into from Mar 27, 2015

Conversation

fioriNTU
Copy link
Contributor

Making changes for summary histos and HLT filering for Online DQM

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_7_3_X.

PixDQM summary fix in 7_3_X

It involves the following packages:

DQM/Integration
DQM/SiPixelMonitorClient

@cmsbuild, @danduggan, @nclopezo, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@danduggan
Copy link
Contributor

please test

On Wed, Mar 25, 2015 at 11:41 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @fioriNTU https://github.com/fioriNTU
for CMSSW_7_3_X.

PixDQM summary fix in 7_3_X

It involves the following packages:

DQM/Integration
DQM/SiPixelMonitorClient

@cmsbuild https://github.com/cmsbuild, @danduggan
https://github.com/danduggan, @nclopezo https://github.com/nclopezo,
@deguio https://github.com/deguio can you please review it and
eventually sign? Thanks.
@threus https://github.com/threus, @batinkov
https://github.com/batinkov this is something you requested to watch as
well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
If you are a L2 or a release manager you can ask for tests by saying
'please test' in the first line of a comment.
@nclopezo https://github.com/nclopezo you are the release manager for
this.
You can merge this pull request by typing 'merge' in the first line of
your comment.


Reply to this email directly or view it on GitHub
#8514 (comment).

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 26, 2015

+1
@danduggan this one should be tested on the playback first.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@danduggan
Copy link
Contributor

@deguio one step ahead of you - running since yesterday ;)

On Thu, Mar 26, 2015 at 1:11 PM, cmsbuild notifications@github.com wrote:

This pull request is fully signed and it will be integrated in one of the
next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull
request requires discussion in the ORP meeting before it's merged.
@davidlange6 https://github.com/davidlange6, @nclopezo
https://github.com/nclopezo, @ktf https://github.com/ktf, @smuzaffar
https://github.com/smuzaffar


Reply to this email directly or view it on GitHub
#8514 (comment).

@deguio
Copy link
Contributor

deguio commented Mar 26, 2015

+1000

@davidlange6
Copy link
Contributor

+1

after a +1000, how can we say no....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants