Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppi and SoftKiller cloning input candidates when they are of PF type #8576

Conversation

ferencek
Copy link
Contributor

Puppi and SoftKiller producers now clone the input candidates if they are of PF type in order to keep things like track Refs, etc. This will enable subjet b tagging for Puppi and SoftKiller jets.

@rappoccio @nhanvtran @violatingcp

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_4_X.

Puppi and SoftKiller cloning input candidates when they are of PF type

It involves the following packages:

CommonTools/PileupAlgos

@nclopezo, @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Mar 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #8576 d8a72b5

Added cloning of PF candidates for Puppi and SoftKiller jets so more information is retained in the PF candidates. This change is in preparation to allow b tagging of subjets but does not change, in itself, processing or output quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-03-27-2300 show no significant differences, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants