New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory leaks in FastTSGFromPropagation #8663
fix memory leaks in FastTSGFromPropagation #8663
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_4_X. fix memory leaks in FastTSGFromPropagation It involves the following packages: FastSimulation/Muons @ssekmen, @nclopezo, @lveldere, @civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 thanks a lot Bill! |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
…ation fix memory leaks in FastTSGFromPropagation
While adding the consumes interface in 7_5_X to class FastTSGFromPropagation, I noticed memory leaks due to allocating products at begin run time (function init()) and not always deleting the previous products first. These need to be fixed in 7_4_X
Rather than deciphering the mess and adding deletes where needed, it was much better and safer just to use smart pointers, rather than bare pointers, for the data members owned by this class.
While I was at it, it was much easier and safer also add the consumes interface, so this PR also includes it.
The justifications are: