Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more missing std qualifiers and includes of iostream header #867

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Sep 17, 2013

After moving from working with CMSSW_7_0_0_pre3 to working with CMSSW_7_0_0_pre4, I discovered several more packages that would not compile against ROOT6 because of missing std qualifiers or missing includes of iostream. This purely technical request fixes those packages. In one place, I also changed two includes of ROOT headers to use quotes instead of angle brackets, as they are not system headers.

Please bypass signatures, as this is purely technical.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Add more missing std qualifiers and includes of iostream header

It involves the following packages:

IOPool/Streamer
PhysicsTools/FWLite
MagneticField/ParametrizedEngine
Alignment/OfflineValidation
CalibTracker/SiPixelGainCalibration
DataFormats/FWLite
CondTools/Ecal
CondCore/RPCPlugins
DQM/BeamMonitor
CalibCalorimetry/EcalCorrectionModules

@apfeiffer1, @Dr15Jones, @demattia, @danduggan, @rovere, @thspeer, @rcastello, @deguio, @slava77, @ggovi, @vadler, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Sep 17, 2013
…issingHeaders

ROOT6 cleanups -- Add more missing std qualifiers and includes of iostream header.
@ktf ktf merged commit 0faf71c into cms-sw:CMSSW_7_0_X Sep 17, 2013
@wmtan wmtan deleted the AddYetMoreMissingStdQualifiersAndMissingHeaders branch October 8, 2013 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants