Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test #8675

Merged
merged 1 commit into from Apr 8, 2015
Merged

Fix unit test #8675

merged 1 commit into from Apr 8, 2015

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Apr 7, 2015

This only affects the DataFormats/FWLite unit
test. Only the ROOT 5 branch unit test is broken,
but I'm adding it to the ROOT 5 and ROOT 6 branches
for consistency.

The dictionary loading in AutoLibraryLoader::enable()
is required in ROOT 5 and not needed in ROOT 6 (that
part actually does nothing in ROOT 6 so AutoLibraryLoader
should probably be renamed). The enable() function
does other things, but those are not needed in this
test. The Ref's are function anyway because of the
GetterOperate mechanism in FWLite that is provided
when using the Event and related classes (but would
not be in bare ROOT mode). This unit test is really a
fully compiled executable and not a macro so the
header finding parts of enable() are not needed either.

This only affects the DataFormats/FWLite unit
test. Only the ROOT 5 branch unit test is broken,
but I'm adding it to the ROOT 5 and ROOT 6 branches
for consistency.

The dictionary loading in AutoLibraryLoader::enable()
is required in ROOT 5 and not needed in ROOT 6 (that
part actually does nothing in ROOT 6 so AutoLibraryLoader
should probably be renamed). The enable() function
does other things, but those are not needed in this
test. The Ref's are function anyway because of the
GetterOperate mechanism in FWLite that is provided
when using the Event and related classes (but would
not be in bare ROOT mode). This unit test is really a
fully compiled executable and not a macro so the
header finding parts of enable() are not needed either.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_5_X.

Fix unit test

It involves the following packages:

DataFormats/FWLite

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

-1
Tested at: 33c0f8b
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 24 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

          ^
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-04-07-1100/src/TrackingTools/TrajectoryState/interface/BasicTrajectoryState.h:89:19: note: overridden virtual function is here
  virtual pointer clone() const=0;
                  ^
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-07-1100/src/RecoParticleFlow/PFSimProducer/plugins/modulesSim.cc 
clang: error: unknown argument: '-fipa-pta'
Entering library rule at src/RecoParticleFlow/PFTracking/plugins
clang: error: unknown argument: '-fipa-pta'
clang: error: unknown argument: '-fipa-pta'
clang: error: unknown argument: '-fipa-pta'
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-04-07-1100/src/RecoMuon/MuonIdentification/src/DTTimingExtractor.cc:50:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8675/2335/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@wddgit
Copy link
Contributor Author

wddgit commented Apr 8, 2015

Note that the test failure is unrelated to this PR. It should not slow down approval and merging.

davidlange6 added a commit that referenced this pull request Apr 8, 2015
@davidlange6 davidlange6 merged commit 8ece62c into cms-sw:CMSSW_7_5_X Apr 8, 2015
@wddgit wddgit deleted the fixFWLiteUnitTest branch June 25, 2015 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants