Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix in SiStripHotStripAlgorithmFromClusterOccupancy #8686

Merged
merged 2 commits into from Apr 10, 2015

Conversation

suchandradutta
Copy link
Contributor

A parameter _NEmptyBins needed to get initialised for each APV before the iterative search to find hot strips

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for CMSSW_7_5_X.

bug fix in SiStripHotStripAlgorithmFromClusterOccupancy

It involves the following packages:

CalibTracker/SiStripQuality

@cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks.
@jlagram, @gbenelli, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Apr 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

Pull request #8686 was updated. @cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

@mmusich
Copy link
Contributor

mmusich commented Apr 9, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8686/4143/summary.html
There are some workflows for which there are errors in the baseline:
9.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants