Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcc-ntupler-74X-v1 #8702

Merged
merged 5 commits into from Apr 23, 2015
Merged

Conversation

capalmer85
Copy link
Contributor

This is the updated version of the pixel cluster counting ntupler from Run1.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @capalmer85 for CMSSW_7_5_X.

pcc-ntupler-74X-v1

It involves the following packages:

RecoLuminosity/LumiProducer

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Apr 12, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #8702 was updated. @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Apr 23, 2015

+1

for #8702 a59247a
changes in the follow up to the code review comments are implemented.
(jenkins compiled this without errors)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

davidlange6 added a commit that referenced this pull request Apr 23, 2015
@davidlange6 davidlange6 merged commit 845dafd into cms-sw:CMSSW_7_5_X Apr 23, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8702/8494/summary.html

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants