New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Not Working leading edge recovery for saturated ECAL RecHits (7_4_X back-port) #8720
Disable Not Working leading edge recovery for saturated ECAL RecHits (7_4_X back-port) #8720
Conversation
…rated rechit producers
…ration happens on the 5th. Use the 5th sample measurement otherwise, to give an estimate of the in-time energy
A new Pull Request was created by @emanueledimarco (Emanuele Di Marco) for CMSSW_7_4_X. Disable Not Working leading edge recovery for saturated ECAL RecHits (7_4_X back-port) It involves the following packages: RecoLocalCalo/EcalRecProducers @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test Some more details on the physics impact are needed here. (Response changes, fraction of hits affected, data vs mc) |
... ok, there are details in the 75x commit |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 for #8720 e62dab2 Briefly: changes are only at very high energies for saturated crystals; at least in a sample fairly close to the saturation phase space the changed code doesn't show significant changes in performance. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Disable Not Working leading edge recovery for saturated ECAL RecHits (7_4_X back-port)
@argiro @cerminar @pierinim @ferriff @crovelli @paramatti please also follow this.