Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca8 Latest changes to meet calibration codes for HCAL #8745

Merged
merged 1 commit into from Apr 30, 2015

Conversation

bsunanda
Copy link
Contributor

Small changes to AlCa code; facility to look into HBHE muon calibration systematics and a few cfg files

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_7_5_X.

bsunanda:Run2-alca8 Latest changes to meet calibration codes for HCAL

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/IsolatedParticles
DQMOffline/CalibCalo

@diguida, @danduggan, @cerminar, @cmsbuild, @nclopezo, @deguio, @mmusich can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Apr 15, 2015

+1
the DQM configs still use EDM format instead of DQMIO, but I don't see a problem

@mmusich
Copy link
Contributor

mmusich commented Apr 15, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

limit = cms.untracked.int32(-1)
)
)
)

process.load("Configuration.Geometry.GeometryIdeal_cff")
process.load("MagneticField.Engine.autoMagneticFieldProducer_cfi")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, please move to condDBv2:

from Configuration.AlCa.autoCond_condDBv2 import autoCond
 process.GlobalTag.globaltag=autoCond['run2_mc']

@diguida
Copy link
Contributor

diguida commented Apr 30, 2015

+1
The code changes are satisfactory.
There are few issues related to consuming new condition DB backend. Not problematic, as they are only in tests, but to be fixed in another PR: we suggest @bsunanda to review all the test files and make one PR with all changes therein.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants