bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL #8752

bsunanda · 2015-04-15T15:19:08Z

Many parts of the trigger code and AlCa codes are modified and they are tested in 7_5_X and also with 7_4_X it passes the runTheMatrix.py with 10 10 9 7 6 tests passed, 0 0 0 0 0 failed

…s for HCAL

cmsbuild · 2015-04-15T15:21:58Z

A new Pull Request was created by @bsunanda for CMSSW_7_4_X.

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalIsolatedTrackReco
Calibration/IsolatedParticles
DQMOffline/CalibCalo
DataFormats/HcalIsolatedTrack

@diguida, @cvuosalo, @cerminar, @cmsbuild, @nclopezo, @deguio, @slava77, @mmusich, @danduggan can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2015-04-15T17:40:57Z

@cmsbuild please test

cmsbuild · 2015-04-15T17:41:49Z

The tests are being triggered in jenkins.

cmsbuild · 2015-04-15T19:20:12Z

+1
Tested at: e79d194
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8752/7175/summary.html

bsunanda · 2015-04-28T20:24:15Z

Could you please let us know why this pull request is stuck? We need this to go through to get HCAL offline calibration in process. In fact we have one more request in line. We like to make that request after this is integrated. Can you treat this urgently? Regards

From: deguio [notifications@github.com]
Sent: 17 April 2015 18:42
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL (#8752)

+1

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8752#issuecomment-94024062.

slava77 · 2015-04-28T20:49:32Z

(the primary signature, from AlCa is missing)

diguida · 2015-04-29T07:10:25Z

@slava77 @cvuosalo @bsunanda
Sorry, we are overwhelmed: looking into it

diguida · 2015-04-30T07:27:11Z

Calibration/HcalAlCaRecoProducers/test/AlCaDiJetsProducer_cfg.py

+process.load("Configuration.StandardSequences.MagneticField_cff")
+process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')
+from Configuration.AlCa.autoCond_condDBv2 import autoCond
+process.GlobalTag.globaltag=autoCond['run2_mc']


@bsunanda
Two fixes in these tests (for a later PR):

Use process.load('Configuration.StandardSequences.GeometryRecoDB_cff') as explained by Ianna in one of the latest meetings: you need Run2 reco geometry.

Use process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_condDBv2_cff') in order to load conditions from the new backend.

diguida · 2015-04-30T07:32:39Z

+1
Backport of #8649 and #7805 for 75X, updating several calibration schemes. The two 75X PRs have already been merged.
Fixes in the tests (see https://github.com/cms-sw/cmssw/pull/8752/files#r29408234) to be addressed in a later PR.

cmsbuild · 2015-04-30T07:35:43Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

abdoulline · 2015-05-05T13:19:11Z

@davidlange6
David, may we have it merged to get it in the next 74X (patch)?

bsunanda · 2015-05-11T20:00:26Z

Hi David, it will be nice to have this merged. We would like to backport a few things more to make the AlCa steps working correctly in 7_4_X. Regards Sunanda

From: abdoulline [notifications@github.com]
Sent: 05 May 2015 15:19
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL (#8752)

@davidlange6 https://github.com/davidlange6
David, may we have it merged to get it in the next 74X (patch)?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8752#issuecomment-99075759.

davidlange6 · 2015-05-12T12:53:46Z

Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cc

+
+  edm::Handle<edm::PCaloHitContainer> calosimhits;
+  iEvent.getByLabel("g4SimHits","HcalHits",calosimhits);
+


@bsunanda - could you add the consumes migration to this module. Thanks

Hi David

I shall add this. I am preparing the next backporting based on 8943. I shall add it there. Would it be OK? Otherwise it will be a huge amount. Regards

Sunanda

From: David Lange [notifications@github.com]
Sent: 12 May 2015 14:53
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL (#8752)

In Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cchttps://github.com//pull/8752#discussion_r30129923:

+//
+// member functions
+//
+
+// ------------ method called for each event ------------
+void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {
+

clearVectors();

RunNumber = iEvent.id().run();

EventNumber = iEvent.id().event();

LumiNumber = iEvent.id().luminosityBlock();

BXNumber = iEvent.bunchCrossing();

edm::Handleedm::PCaloHitContainer calosimhits;

iEvent.getByLabel("g4SimHits","HcalHits",calosimhits);

@bsunandahttps://github.com/bsunanda - could you add the consumes migration to this module. Thanks

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8752/files#r30129923.

@bsunanda - could you not just push the change to this branch? Then its a few lines that get picked up easily and we aren’t back porting incorrect code.

On May 12, 2015, at 3:35 PM, bsunanda notifications@github.com wrote:

In Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cc:

+//
+// member functions
+//
+
+// ------------ method called for each event ------------
+void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {

clearVectors();

RunNumber = iEvent.id().run();

EventNumber = iEvent.id().event();

LumiNumber = iEvent.id().luminosityBlock();

BXNumber = iEvent.bunchCrossing();

edm::Handleedm::PCaloHitContainer calosimhits;

iEvent.getByLabel("g4SimHits","HcalHits",calosimhits);

Hi David I shall add this. I am preparing the next backporting based on 8943. I shall add it there. Would it be OK? Otherwise it will be a huge amount. Regards Sunanda ________________________________ From: David Lange [notifications@github.com] Sent: 12 May 2015 14:53 To: cms-sw/cmssw Cc: Sunanda Banerjee Subject: Re: [cmssw] bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL (#8752) In Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cchttps://github.com//pull/8752#discussion_r30129923:
+// +// member functions +// + +// ------------ method called for each event ------------ +void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) { + + clearVectors(); + RunNumber = iEvent.id().run(); + EventNumber = iEvent.id().event(); + LumiNumber = iEvent.id().luminosityBlock(); + BXNumber = iEvent.bunchCrossing(); + + edm::Handleedm::PCaloHitContainer calosimhits; + iEvent.getByLabel("g4SimHits","HcalHits",calosimhits); +
@bsunandahttps://github.com/bsunanda - could you add the consumes migration to this module. Thanks — Reply to this email directly or view it on GitHubhttps://github.com//pull/8752/files#r30129923.
—
Reply to this email directly or view it on GitHub.

Hi David
I have committed the version of Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cchttps://github.com//pull/8752#discussion_r30152293 which uses tokens, initialized in the constructor. Hope this is ok. Regards
Sunanda

From: David Lange [notifications@github.com]
Sent: 12 May 2015 18:25
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL (#8752)

In Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cchttps://github.com//pull/8752#discussion_r30152293:

+//
+// member functions
+//
+
+// ------------ method called for each event ------------
+void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {
+

clearVectors();

RunNumber = iEvent.id().run();

EventNumber = iEvent.id().event();

LumiNumber = iEvent.id().luminosityBlock();

BXNumber = iEvent.bunchCrossing();

edm::Handleedm::PCaloHitContainer calosimhits;

iEvent.getByLabel("g4SimHits","HcalHits",calosimhits);

@bsunandahttps://github.com/bsunanda - could you not just push the change to this branch? Then its a few lines that get picked up easily and we aren’t back porting incorrect code.
…
On May 12, 2015, at 3:35 PM, bsunanda notifications@github.com wrote: In Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cc: > +// > +// member functions > +// > + > +// ------------ method called for each event ------------ > +void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) { > + > + clearVectors(); > + RunNumber = iEvent.id().run(); > + EventNumber = iEvent.id().event(); > + LumiNumber = iEvent.id().luminosityBlock(); > + BXNumber = iEvent.bunchCrossing(); > + > + edm::Handleedm::PCaloHitContainer calosimhits; > + iEvent.getByLabel("g4SimHits","HcalHits",calosimhits); > + Hi David I shall add this. I am preparing the next backporting based on 8943. I shall add it there. Would it be OK? Otherwise it will be a huge amount. Regards Sunanda ________________________________ From: David Lange [notifications@github.com] Sent: 12 May 2015 14:53 To: cms-sw/cmssw Cc: Sunanda Banerjee Subject: Re: [cmssw] bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL (#8752 #8752) In Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cchttps://github.com//pull/8752#discussion_r30129923: +// +// member functions +// + +// ------------ method called for each event ------------ +void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) { + + clearVectors(); + RunNumber = iEvent.id().run(); + EventNumber = iEvent.id().event(); + LumiNumber = iEvent.id().luminosityBlock(); + BXNumber = iEvent.bunchCrossing(); + + edm::Handleedm::PCaloHitContainer calosimhits; + iEvent.getByLabel("g4SimHits","HcalHits",calosimhits); + @bsunandahttps://github.com/bsunandahttps://github.com/bsunanda - could you add the consumes migration to this module. Thanks — Reply to this email directly or view it on GitHubhttps://github.com//pull/8752/files#r30129923. — Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/8752/files#r30152293.

davidlange6 · 2015-05-12T17:06:34Z

@cmsbuild, please test

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL

Sunanda added 3 commits April 15, 2015 17:11

Backport PRs from 7_5 to handle calibration trigger and AlCa Reco job…

468857c

…s for HCAL

Second part of the backporting

e64aab5

Third part of the backporting

e79d194

cmsbuild added this to the Next CMSSW_7_4_X milestone Apr 15, 2015

cmsbuild added alca-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 15, 2015

cmsbuild added alca-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending tests-started and removed alca-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 15, 2015

cmsbuild removed the alca-pending label Apr 15, 2015

cmsbuild added pending-signatures reconstruction-approved tests-approved labels Apr 17, 2015

diguida reviewed Apr 30, 2015
View reviewed changes

cmsbuild removed alca-pending comparison-available dqm-approved orp-pending pending-signatures reconstruction-approved tests-approved labels Apr 30, 2015

cmsbuild added alca-approved comparison-available dqm-approved fully-signed orp-pending reconstruction-approved tests-approved labels Apr 30, 2015

davidlange6 reviewed May 12, 2015
View reviewed changes

get rid of getByLabel usage

af189b5

davidlange6 added a commit that referenced this pull request May 12, 2015

Merge pull request #8752 from bsunanda/Run2-alca9

7ba2b5a

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL

davidlange6 merged commit 7ba2b5a into cms-sw:CMSSW_7_4_X May 12, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL #8752

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL #8752

bsunanda commented Apr 15, 2015

cmsbuild commented Apr 15, 2015

slava77 commented Apr 15, 2015

cmsbuild commented Apr 15, 2015

cmsbuild commented Apr 15, 2015

bsunanda commented Apr 28, 2015

slava77 commented Apr 28, 2015

diguida commented Apr 29, 2015

diguida Apr 30, 2015

diguida commented Apr 30, 2015

cmsbuild commented Apr 30, 2015

abdoulline commented May 5, 2015

bsunanda commented May 11, 2015

davidlange6 May 12, 2015

bsunanda May 12, 2015

davidlange6 May 12, 2015

bsunanda May 12, 2015

davidlange6 commented May 12, 2015


		edm::Handle<edm::PCaloHitContainer> calosimhits;
		iEvent.getByLabel("g4SimHits","HcalHits",calosimhits);

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL #8752

bsunanda:Run2-alca9 Backport PRs from 7_5 to handle calibration trigger and AlCa Reco jobs for HCAL #8752

Conversation

bsunanda commented Apr 15, 2015

cmsbuild commented Apr 15, 2015

slava77 commented Apr 15, 2015

cmsbuild commented Apr 15, 2015

cmsbuild commented Apr 15, 2015

bsunanda commented Apr 28, 2015

slava77 commented Apr 28, 2015

diguida commented Apr 29, 2015

diguida Apr 30, 2015

Choose a reason for hiding this comment

diguida commented Apr 30, 2015

cmsbuild commented Apr 30, 2015

abdoulline commented May 5, 2015

bsunanda commented May 11, 2015

davidlange6 May 12, 2015

Choose a reason for hiding this comment

bsunanda May 12, 2015

Choose a reason for hiding this comment

davidlange6 May 12, 2015

Choose a reason for hiding this comment

+// +// member functions +// + +// ------------ method called for each event ------------ +void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {

bsunanda May 12, 2015

Choose a reason for hiding this comment

davidlange6 commented May 12, 2015

+//
+// member functions
+//
+
+// ------------ method called for each event ------------
+void HcalRaddamMuon::analyze(const edm::Event& iEvent, const edm::EventSetup& iSetup) {