New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing reversed distance in accessing subjet collections #8754
Fixing reversed distance in accessing subjet collections #8754
Conversation
A new Pull Request was created by @rappoccio for CMSSW_7_5_X. Fixing reversed distance in accessing subjet collections It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks. |
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Fixing reversed distance in accessing subjet collections
The order of the iterators in "std::distance" was reversed, giving negative numbers (and hence nonsense when dereferencing the index).