update isSoftMuon( ) to use new soft muon Id

[dayongwang]

Update isSoftMuon( ) to use new soft muon Id . The changes affect only analyses and not RECO or data format. This can be included whenever convenient.

[cmsbuild]

A new Pull Request was created by @dayongwang for CMSSW_7_2_X.

update isSoftMuon( ) to use new soft muon Id

It involves the following packages:

DataFormats/MuonReco

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @trocino, @amagitte, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

What's the plan for remaining 7X releases? Are you planning to propagate to 74X and 75X
or will these releases have a different isSiftMuon?

[slava77]

@cmsbuild please test

[dayongwang]

@slava77 this fix was already there starting from CMSSW_7_3_0. This is just a backport to CMSS_7_2_X. Pull#8761 is the same backport to CMSSW_5_3_X

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 4224dc8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8762/4254/summary.html

[slava77]

+1

for #8762 4224dc8

• code changes are the same as in 73X; they apply only to analysis-level parts of the code
• jenkins comparisons show no differences in stored RECO products
• jenkins comparisons show differences in DQM histograms filled with isSoftMuon ID function applied, as expected from the code change.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlange6]

+1

[slava77]

@battibass @trocino
you can probably now update the twiki
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideMuonId#Soft_Muon
the function is now in 7_2_5 release

[battibass]

@slava77 done, thanks!