Avoid segfault in edmProvDump -d when parentage ID is out of bounds #8815
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_5_X. Avoid segfault in edmProvDump -d when parentage ID is out of bounds It involves the following packages: IOPool/Common @cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
please check |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
cmsbuild
added
comparison-pending
core-approved
fully-signed
and removed
comparison-pending
core-approved
fully-signed
orp-pending
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
+1 |
Avoid segfault in edmProvDump -d when parentage ID is out of bounds
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
edmProvDump -d currently will segfault if the input file has a parentage ID that is out of bounds.
This totally trivial PR simply changes the std:;vector square bracket operator to the at() function so that an out of bounds exception will be thrown instead of a segfault.